On Tue, Jun 27, 2017 at 09:40:02PM +0200, Stefan Lengfeld wrote: > Hi Uwe, > > Just my too cents: > > On Tue, Jun 27, 2017 at 09:03:17PM +0200, Uwe Kleine-König wrote: > > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > +++ b/arch/arm/boards/udoo-neo/flash-header-mx6sx-udoo-neo_full.imxcfg > > @@ -0,0 +1,124 @@ > > +loadaddr 0x80000000 > > +soc imx6 > > +dcdofs 0x400 > > I'm always wondering where the magic values in the flash headers are > coming from. Whether they are copied from u-boot or another > variant/board or completely self-made or provided by a friendly hardware > engineer in an Excel sheet ;-) Maybe you can add a comment here or in > the commit message. But this would be a new convention, because I have > not seen it in other flash headers yet. Adding this information is a good idea. In this case the values come from: /* * These values are taken from: * repository: https://github.com/UDOOboard/uboot-imx * branch: udoo/2015.04.imx * file: board/udoo/udoo_neo/udoo_neo_basic.cfg */ I was about to apply Uwes patch along with this comment, but I just realized that the values are from udoo_neo_basic whereas the patch seems to support the udoo_neo_full. The udoo neo full has slightly different calibration values in the branch above, but probably they work on both boards. Uwe, do you know which hardware we actually have and support? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
