Re: [PATCH 32/45] usb: ohci-at91: Check result of clk_get()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 06, 2017 at 02:53:43PM -0800, Andrey Smirnov wrote:
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
>  drivers/usb/host/ohci-at91.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
> index 0f5c8f1..c70d898 100644
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c
> @@ -47,7 +47,16 @@ static int at91_ohci_probe(struct device_d *dev)
>  	struct ohci_regs __iomem *regs = (struct ohci_regs __iomem *)dev->resource[0].start;
>  
>  	iclk = clk_get(NULL, "ohci_clk");
> +	if (IS_ERR(iclk)) {
> +		dev_err(dev, "Failed to get 'iclk'\n");
iclk is the internal name. Woudl it make more sense to use "ohci_clk" here?

> +		return PTR_ERR(iclk);
> +	}
> +
>  	fclk = clk_get(NULL, "uhpck");
> +	if (IS_ERR(fclk)) {
> +		dev_err(dev, "Failed to get 'fclk'\n");
Likewise - uhpck?


_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux