On Fri, Dec 23, 2016 at 10:50:46AM +0100, Uwe Kleine-König wrote: > Hello, > > On Fri, Dec 23, 2016 at 10:45:49AM +0100, Uwe Kleine-König wrote: > > dev->detect = pata_imx_detect; > > BTW, another thing I noticed while reading through this driver is: > > pata_imx_detect is a wrapper around ata_port_detect. Later in > imx_pata_probe the function ide_port_register is called which also calls > ata_port_detect. > > I don't have a machine handy where I could test, but I guess > pata_imx_detect could be dropped. (Or alternatively ide_port_register > could be reworked and all callers fixed to setup a detect call.) ide_port_register() has: ret = ata_port_register(&ide->port); if (!ret) ata_port_detect(&ide->port); The call to ata_port_detect() goes back to: commit 9c8f73ba86884026f4bbfc6f593d73741cfebcdc Author: Michel Stam <m.stam@xxxxxxxx> Date: Mon Apr 7 12:01:21 2014 +0200 The hunk adding ata_port_detect() is wrong as it shortcircuits the optional detection mechanism. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
