Hello, On Fri, Dec 23, 2016 at 10:45:49AM +0100, Uwe Kleine-König wrote: > dev->detect = pata_imx_detect; BTW, another thing I noticed while reading through this driver is: pata_imx_detect is a wrapper around ata_port_detect. Later in imx_pata_probe the function ide_port_register is called which also calls ata_port_detect. I don't have a machine handy where I could test, but I guess pata_imx_detect could be dropped. (Or alternatively ide_port_register could be reworked and all callers fixed to setup a detect call.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
