Re: [PATCH v2] input: usb keyboard: fix CTRL+C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2016-02-24 at 19:12 +0100, Sascha Hauer wrote:
> > > >  
> > > > -	if (modstate & (1 << 0))
> > > > +	if (modstate & (1 << 1))
> > > > +		ascii = keycode_bb_ctrl_keys[ev->code];
                
           ascii = keycode_bb_keys[ev->code];
           ascii = ascii >= 'a' ? CTL_CH(ascii): 0;

> > Sasha, did you mean to eliminate the CTRL-keymap completely?
> 
> No, I didn't, although that would be an option aswell. It would safe us
> a few more bytes in the binary. The question is, how many more keys are
> in the CTRL map that are interesting for us? Are there more than CTRL-C?
> If yes, then it's probably better to keep the map. If not, a special
> CTRL-C case in code might be the better option.

Would the above, or a slight modification, be ok?  It gets almost all
the controls keys one could care about.

Ignoring control for all keys other than c doesn't make sense to me.
Does anything else do that?
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux