On Fri, Feb 19, 2016 at 11:12:24AM -0800, Andrey Smirnov wrote: > >> > >> // Fix the check itself. Having this as a standalone rule allows > >> // to catch cases where error codepath doesn't bail out > >> @depends on i@ > > > > I assume you mean "depends on rule1", because otherwise it never > > actually changes the wrong error check. > > > > Darn! I missed that regression. The problem with making it depending > on "rule1" is that it misses the cases where only the incorrect check > is performed and no bailing out is done (atmel_nand.c). > > > > Overall this looks better than my version. I recreated the patch with > > your version and fixed up the altera-tse driver manually. > > In case you missed it there's also "dove.c" that needs to be corrected manually. Yes, I missed it. Fixed up manuelly now. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
