On Mon, 2016-02-01 at 15:07 +0100, Tim Sander wrote:
> v3: forgot to amend my changes in v2.
>
> +
> +static int socfpga_console_init(void)
> +{
> + if (!of_machine_is_compatible("altr,socfpga-cyclone5"))
> + return 0;
Seems like this should be a board specific check instead of a generic
one, since it's programming board specific phy timing values to a board
specific PHY.
> +
> + if (IS_ENABLED(CONFIG_PHYLIB))
> + phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK, phy_fixup);
> +
> + return 0;
> +}
> +
> +static inline void ledon(int led)
> +{
> + u32 val;
> +
> + val = readl(0xFF709000);
> + val |= 1 << (led + 24);
> + writel(val, 0xFF709000);
There a macro CYCLONE5_GPIO1_BASE that could be used instead of
0xFF709000.
> +
> + val = readl(0xFF709004);
> + val |= 1 << (led + 24);
> + writel(val, 0xFF709004);
> +}
> +
> +static inline void ledoff(int led)
> +{
> + u32 val;
> +
> + val = readl(0xFF709000);
> + val &= ~(1 << (led + 24));
> + writel(val, 0xFF709000);
> +
> + val = readl(0xFF709004);
> + val &= ~(1 << (led + 24));
> + writel(val, 0xFF709004);
> +}
> +#include <arm/socfpga_cyclone5_de0_nano_soc.dts>
> +#include "socfpga.dtsi"
> +
> +/ {
> + model = "Terasic DE0-Nano-SoC (Atlas)";
> + compatible = "altr,socfpga-cyclone5", "altr,socfpga";
Wouldn't the right thing to do here be to have a compatible entry for
this board type? Like the existing "terasic,sockit" or something more
specific.
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
