Instead of displaying the status of PHY "PHY" the tool will print status
of all PHYs it encounters while searching for the one that was
requested. This commit fixes the logic such that only requested
information is printed.
Signed-off-by: Andrey Gusakov <andrey.gusakov@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
---
commands/miitool.c | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/commands/miitool.c b/commands/miitool.c
index c62e758..9ee3597 100644
--- a/commands/miitool.c
+++ b/commands/miitool.c
@@ -233,18 +233,27 @@ static void mdiobus_show(struct device_d *dev, char *phydevname, int verbose)
struct phy_device *phydev;
phydev = mdiobus_scan(mii, i);
- if (IS_ERR(phydev))
+ if (IS_ERR(phydev) || !phydev->registered)
continue;
- if (phydev->registered) {
- show_basic_mii(mii, phydev, verbose);
+ /*
+ * If we are looking for a secific phy, called
+ * 'phydevname', but current phydev is not it, skip to
+ * the next iteration
+ */
+ if (phydevname &&
+ strcmp(phydev->cdev.name, phydevname))
+ continue;
- if (phydevname &&
- !strcmp(phydev->cdev.name, phydevname)) {
- return;
- }
- }
+ show_basic_mii(mii, phydev, verbose);
+ /*
+ * We were looking for a specific device and at this
+ * point we already shown the info about it so end the
+ * loop and exit
+ */
+ if (phydevname)
+ break;
}
return;
--
2.5.0
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
