On Wed, Nov 11, 2015 at 08:54:01PM +0000, Trent Piepho wrote: > The dw MAC requires that all clock domains to be running for it to > finish a MAC reset. This include the clock provided by the PHY. > > If the PHY is powered down, bit BMCR_PDOWN set, then it won't be > generating a clock. And so the MAC never comes out of reset. On > shutdown, Linux will put the PHY in powerdown mode, so it can easily > be the case that the PHY is powered down on boot. > > See Linux kernel commit 2d871aa07136fe6e576bde63072cf33e2c664e95. > > Currently the MAC reset is done before the phy is probed. We can't > power up the phy until it's probed, so the resets must be in the > opposite order. The MAC reset is in device init but the PHY probe is > in device open. Device init is done first, always, while open is done > later, and only if the device is used. > > Rather than move the phy probe to init, this moves the MAC reset to > open. It seems better to speed up boots that doesn't use ethernet by > skipping MAC reset than to slow them down by adding PHY probe. > > Signed-off-by: Trent Piepho <tpiepho@xxxxxxxxxxxxxx> > --- > > Ignore v2, I missed a bunch of compiler warnings that scrolled off the > screen and barebox doesn't seem to be using -Werror. Newer compilers tend to introduce more warnings, so using -Werror would mean that an older barebox will likely not build with recent compiler versions. I had this problem with other projects sometimes, so I don't think that using -Werror is a good idea. Anyway, applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
