On 15.10.2015 11:00, Thomas Petazzoni wrote:
On Thu, 15 Oct 2015 10:18:55 +0200, Sascha Hauer wrote:
The BINARY files given in the config files are expected to be relative
to the place kwbimage is called from. This is bad since it breaks where
kwbimage is called from the build directory and not the source
directory.
It makes more sense to make the paths in the config files relative
to the config files which works with out of tree builds and is also
more what a user normally expects.
Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
In practice those binary.0 files are not really part of the Barebox
source code. The binary.0 file has to be extracted from a vendor U-Boot
binary prior to doing the Barebox build, so it isn't exactly part of
the "source tree".
Though I agree it is probably easier to extract them once and keep them
around in the source tree (not checked-in, of course).
Sascha,
I am fine with making the path relative to kwbimage.cfg, although I'd
make it even more explicit by putting a './' in from of the binary.0
in each kwbimage.cfg.
Note that U-Boot now has a fully open-source implementation of this
binary.0 thing, at least for Armada XP and Armada 38x. However, it's
basically copy/pasted from the vendor U-Boot, so it's not very pretty
to look at:
Interesting, thanks for the links.
- http://git.denx.de/?p=u-boot.git;a=tree;f=drivers/ddr/marvell
for the DDR initialization code.
I think it would be nice to have the DDR init code in barebox, however..
- http://git.denx.de/?p=u-boot.git;a=tree;f=arch/arm/mach-mvebu/serdes
for the SERDES lane initialization
... I don't see why SERDES init is important that early (for production
use). I think SERDES init should be/stay part of the PHY init code we
already have.
Sebastian
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
