On Wed, 16 Sep 2015 10:50:33 +0300 Antony Pavlov <antonynpavlov@xxxxxxxxx> wrote: > On Wed, 16 Sep 2015 14:40:48 +0800 > Kevin Du Huanpeng <u74147@xxxxxxxxx> wrote: > > > Signed-off-by: Kevin Du Huanpeng <u74147@xxxxxxxxx> > > --- > > arch/mips/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > > index aeb5c04..fde4c2e 100644 > > --- a/arch/mips/Kconfig > > +++ b/arch/mips/Kconfig > > @@ -6,6 +6,7 @@ config MIPS > > select HAS_KALLSYMS > > select HAVE_CONFIGURABLE_MEMORY_LAYOUT > > select HAVE_CONFIGURABLE_TEXT_BASE > > + select BANNER > > default y > > > > config SYS_SUPPORTS_BIG_ENDIAN > > -- > > 1.9.1 > > > > IMHO we can make banner use in start.S optional. E.g.: > > diff --git a/arch/mips/boot/start.S b/arch/mips/boot/start.S > index 7e2ae5e..f3a6a00 100644 > --- a/arch/mips/boot/start.S > +++ b/arch/mips/boot/start.S > @@ -22,8 +22,10 @@ > #include <asm/mipsregs.h> > #include <asm/asm.h> > #include <asm-generic/memory_layout.h> > +#ifdef CONFIG_BANNER > #include <generated/compile.h> > #include <generated/utsrelease.h> > +#endif > > /* > * ADR macro instruction (inspired by ARM) > @@ -52,6 +54,7 @@ _pc: addiu \rd, ra, \label - _pc # label is assumed to be > > EXPORT(_start) > > +#ifdef CONFIG_BANNER > b __start > nop > > @@ -60,6 +63,8 @@ EXPORT(_start) > .byte 0 > > .align 4 > +#endif /* CONFIG_BANNER */ I see just the same code in the mips_barebox_10h macro from arch/mips/include/asm/pbl_macros.h. > + > __start: > /* disable watchpoints */ > mtc0 zero, CP0_WATCHLO > > Or even add an separate option to include utsrelease information into start.S. > > -- > Best regards, > Antony Pavlov -- -- Best regards, Antony Pavlov _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
