When a of_fixup handler fails add a meaningful error message so that the user gets a clue what might have gone wrong. Suggested-by: Enrico Joerns <ejo@xxxxxxxxxxxxxx> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> --- common/oftree.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/common/oftree.c b/common/oftree.c index f75d7b4..cafe46c 100644 --- a/common/oftree.c +++ b/common/oftree.c @@ -189,8 +189,11 @@ int of_fix_tree(struct device_node *node) list_for_each_entry(of_fixup, &of_fixup_list, list) { ret = of_fixup->fixup(node, of_fixup->context); - if (ret) + if (ret) { + pr_err("Failed to fixup node in %pS: %s\n", + of_fixup->fixup, strerror(-ret)); return ret; + } } return 0; -- 2.5.0 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox