Hi, Sascha! On Thu, 3 Sep 2015 20:16:36 +0200 Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > On Thu, Sep 03, 2015 at 07:31:55PM +0300, Antony Pavlov wrote: > > On Thu, 03 Sep 2015 17:46:32 +0200 > > Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: > > > > > Hi Peter. > > > > > > Sorry, but this patch is wrong. You can't just make up completely > > > ad-hoc DT bindings. You are pushing platformdata 1:1 into the DT, > > > which is not how the conversion to DT should be done. > > > > > > There is also no pre-existing binding for "ata-generic" in the > > > Linux kernel which would define any of those properties. > > > > Hmmm. in linux-4.2/drivers/ata/pata_of_platform.c I see > > "ata-generic" with "reg-shift" and "pio-mode" properties. > > It seems this binding comes from the good old days when writing > binding doc was an optional task ;) > > Sascha > So, do we need this linux-like binding in barebox, or should we prefer a soc-specific approach, as Lucas described: > Most likely your IDE controller is inside some SoC specific block, > with a specific compatible, which may also handle clocks and other > required stuff and that one should instantiate the IDE driver if > needed. ? Peter _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
