On Mon, Aug 24, 2015 at 01:32:15PM +0200, Daniel Schultz wrote: > Added missing defines for the extended CSD register until standard 5.1. > > Signed-off-by: Daniel Schultz <d.schultz@xxxxxxxxx> > --- > include/mci.h | 188 ++++++++++++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 143 insertions(+), 45 deletions(-) > > diff --git a/include/mci.h b/include/mci.h > index a7bf8cd..dfeca46 100644 > --- a/include/mci.h > +++ b/include/mci.h > @@ -137,51 +137,149 @@ > * EXT_CSD fields > */ > > -#define EXT_CSD_FLUSH_CACHE 32 /* W */ > -#define EXT_CSD_CACHE_CTRL 33 /* R/W */ > -#define EXT_CSD_POWER_OFF_NOTIFICATION 34 /* R/W */ > -#define EXT_CSD_GP_SIZE_MULT 143 /* R/W */ Please do not change the whitespaces in existing defines. Better some whitespaces inconstistencies but a better to review patch. Also you are using some of the defines in 1/3, so this patch should be before it, right? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox