On Thu, May 14, 2015 at 10:33 PM, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > On Wed, May 13, 2015 at 07:54:18PM -0700, Andrey Smirnov wrote: >> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> >> --- >> common/memtest.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) > > > I have applied the memtest patches for now. I'll come to the PBL console > input patches next week when I find some time. I think I haven't made my > mind yet whether we really want to have input support in PBL and where > this all leads to. We use functions which were originally meant for > debugging to do regular output with PBL console support. Maybe we should > clean this up and introduce some real early console backend rather than > abusing the debugging functions before we add more features to it. > I agree that it seems to start to look like too much of a code duplication, FWIW, my main intention with adding input support to PBL was to allow for more interactivity in hang() handler(like being able to send a very primitive command to reset the board, instead of relying on external reset circuitry). I am not sure how this can be improved, so if you have any ideas of how to better introduce the same functionality I'll be happy to help on implementing it. > Sascha > > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
