Ommiting offset 0 from address line tests allows certain corner cases of faults to be undetected. For the "stuck high" case, consider scenario in which all of the tested address lines are stuck high. In original code first data filling loop would execute writing data to a single cell multiple times and second loop would just read data from that cell over and over again. Adding a write to start[0] should prevent this since it would cause the second loop to read incorrect data on its first iteration. For the "stuck low" case, having any of the tested bits of the address shorted would effectively "remap" that memory cell to start[0] in this case excluding start[0] during the verification phase would result in a false positive result. Note that both of the changes are present in Michael Barr's code here: http://www.esacademy.com/en/library/technical-articles-and-documents/miscellaneous/software-based-memory-testing.html and the code in barebox is based on that code. Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> --- common/memtest.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/common/memtest.c b/common/memtest.c index 3b0bcb7..9eda788 100644 --- a/common/memtest.c +++ b/common/memtest.c @@ -170,6 +170,15 @@ int mem_test(resource_size_t _start, for (offset = 1; offset <= num_words; offset <<= 1) start[offset] = pattern; + /* + * Now write anti-pattern at offset 0. If during the previous + * step one of the address lines got stuck high this + * operation would result in a memory cell at power-of-two + * offset being set to anti-pattern which hopefully would be + * detected byt the loop that follows. + */ + start[0] = anti_pattern; + printf("Check for address bits stuck high.\n"); /* @@ -187,6 +196,11 @@ int mem_test(resource_size_t _start, } } + /* + Restore original value + */ + start[0] = pattern; + printf("Check for address bits stuck " "low or shorted.\n"); @@ -196,7 +210,8 @@ int mem_test(resource_size_t _start, for (offset2 = 1; offset2 <= num_words; offset2 <<= 1) { start[offset2] = anti_pattern; - for (offset = 1; offset <= num_words; offset <<= 1) { + for (offset = 0; offset <= num_words; + offset = (offset) ? offset << 1 : 1) { temp = start[offset]; if ((temp != pattern) && -- 2.1.4 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
