On Sun, Feb 22, 2015 at 10:58:42AM -0700, Doug Brainard wrote: > Bo, > > On Thu, Feb 12, 2015 at 10:52 PM, Bo Shen <voice.shen@xxxxxxxxx> wrote: > > Hi Doug, > > > > On 02/13/2015 01:27 PM, Doug Brainard wrote: > >> > >> Switched SAMA5D4EK development board to the newer environment method. > >> > >> Improved interface to the new environment > >> > >> Create a custom mtdparts-add script to have the partition naming work the > >> same as in the old environment > >> > >> Removed custom mtdparts-add after new patch resolved the issue being seen. > > > > > > I think the upper three line should be under "---", while not in commit > > message. This is what you do between previous version and this version (So > > you need add version to the patch). > > > > Is there an official way to add a patch version? And shouldn't > everything go above the "---" or it will be added to the changed > files? > > >> Signed-off-by: Doug Brainard <dbrainard@xxxxxxxxxxxxxxxxxxx> > >> --- > > > > > > (Put the depends here) > > For example: > > This patch based on "mtd partition handling updates" patch series from > > Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > > > (Put change log here) > > > > For example: > > Changes in v2: > > - Removed custom mtdparts-add after new patch resolved the issue being > > seen. > > > > To add the depends and change log, do I just edit the patch file with > a text editor or is there a command argument to do that? The --annotate option might help you here. I haven't used it before, so I don't know. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox