Hi Robert, On Mon, Jan 05, 2015 at 11:44:38AM +0100, robert.jarzmik@xxxxxxx wrote: > ----- Mail original ----- > De: "Ezequiel Garcia" <ezequiel.garcia@xxxxxxxxxxxxxxxxxx> > À: "Robert Jarzmik" <robert.jarzmik@xxxxxxx>, barebox@xxxxxxxxxxxxxxxxxxx > Envoyé: Dimanche 4 Janvier 2015 19:50:55 > Objet: Re: [PATCH] mtd: nand: add pxa3xx-nand driver > > Hi Robert, > > > If my memory doesn't fail me, the NAND controller is called NFC v1 on > > pxa3xx, and NFC v2 on mvebu SoCs. > > I'm wondering if we can pick a better name for this driver in barebox. > > Maybe something like 'mv_nfc_nand' ? > As all drivers are called "nand_XXX", I'd rather have it nand_mrvl_nfc then. > Does that sound good to you ? > > > Also, I think you can get rid of the 'builtin_flash_types' struct and > > all the device detection routines, which are really duplicating the > > MTD's lower level job. > Well, not really. If I get rid of them, how will I get the following > information : > - page size > - nand timings (tHP, ...) > - controller width to use > - ... Things like mtd->writesize, mtd->erasesize, and mtd->size should be initialized after calling nand_scan_ident(). These are currently overwritten by the pxa nand driver, but normally you should be able to remove this. IIRC barebox can also detect the chip widths automatically. I don't know how to get the timings though. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
