----- Mail original ----- De: "Ezequiel Garcia" <ezequiel.garcia@xxxxxxxxxxxxxxxxxx> À: "Robert Jarzmik" <robert.jarzmik@xxxxxxx>, barebox@xxxxxxxxxxxxxxxxxxx Envoyé: Dimanche 4 Janvier 2015 19:50:55 Objet: Re: [PATCH] mtd: nand: add pxa3xx-nand driver Hi Robert, > If my memory doesn't fail me, the NAND controller is called NFC v1 on > pxa3xx, and NFC v2 on mvebu SoCs. > I'm wondering if we can pick a better name for this driver in barebox. > Maybe something like 'mv_nfc_nand' ? As all drivers are called "nand_XXX", I'd rather have it nand_mrvl_nfc then. Does that sound good to you ? > Also, I think you can get rid of the 'builtin_flash_types' struct and > all the device detection routines, which are really duplicating the > MTD's lower level job. Well, not really. If I get rid of them, how will I get the following information : - page size - nand timings (tHP, ...) - controller width to use - ... > I never removed it from the Linux driver, because I was afraid of > regressions and there are little testers around. However, on Barebox we > can benefit from removing that, and starting with a cleaner driver. If you convince me all the information can be found back, I'll gladly remove them. Cheers. -- Robert -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
