Re: [PATCH 1/3] ARM: dts: am335x-phytec-phyflex: Increase kernel partition on SPI NOR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 09, 2014 at 11:16:47AM +0100, Teresa Gámez wrote:
> Hello Sascha,
> 
> Am Dienstag, den 09.12.2014, 10:13 +0100 schrieb Sascha Hauer:
> > Hi Teresa,
> > 
> > On Mon, Dec 08, 2014 at 10:59:49AM +0100, Teresa Gámez wrote:
> > > Increase kernel partition to end of SPI NOR.
> > > 
> > > Signed-off-by: Teresa Gámez <t.gamez@xxxxxxxxx>
> > > ---
> > >  arch/arm/dts/am335x-phytec-phyflex.dts | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/arm/dts/am335x-phytec-phyflex.dts b/arch/arm/dts/am335x-phytec-phyflex.dts
> > > index c4481f5..0de7e87 100644
> > > --- a/arch/arm/dts/am335x-phytec-phyflex.dts
> > > +++ b/arch/arm/dts/am335x-phytec-phyflex.dts
> > > @@ -187,7 +187,7 @@
> > >  
> > >  		partition@4 {
> > >  			label = "kernel";
> > > -			reg = <0xe0000 0x400000>;
> > > +			reg = <0xe0000 0x0>;
> > >  		};
> > 
> > I wasn't aware barebox handles this case like you intend here. What
> > about the kernel? Won't you end up with a zero sized partition there?
> 
> have a look at include/linux/mtd/partitions.h in the linux kernel.
> 
> There is a macro defined 
> #define MTDPART_SIZ_FULL        (0)
> 
> And the comment above says: 
> size: the partition size; if defined as MTDPART_SIZ_FULL, the partition
> will extend to the end of the master MTD device.
> 
> This works fine for kernel and barebox.

Oh nice, didn't know that. In this case consider your patches applied.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox





[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux