Re: [PATCH 5/7] sha2: fix invalid length check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lucas,

On Mon, Oct 20, 2014 at 08:15:59PM +0200, Lucas Stach wrote:
> length is unsigned an thus can never be <0.
> 
> Signed-off-by: Lucas Stach <dev@xxxxxxxxxx>
> ---
>  crypto/sha2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/sha2.c b/crypto/sha2.c
> index 26162e8..e495313 100644
> --- a/crypto/sha2.c
> +++ b/crypto/sha2.c
> @@ -208,7 +208,7 @@ static void sha2_update(sha2_context * ctx, const uint8_t * input, size_t length
>  	size_t fill;
>  	uint32_t left;
>  
> -	if (length <= 0)
> +	if (length = 0)

should be (length == 0).

- Alex

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux