Looks mostly fine.
On Fri, Aug 01, 2014 at 03:24:23PM +0200, Raphaël Poggi wrote:
> This driver is based on mach-at91/gpio.c and linux pinctrl driver.
> The driver contains the gpio and pinctrl parts (like in linux) because the two parts
> share some structures and logics.
>
> Signed-off-by: Raphaël Poggi <poggi.raph@xxxxxxxxx>
> ---
> +static struct at91_pinctrl_mux_ops *at91_pinctrl_get_driver_data(struct device_d *dev)
> +{
> + struct at91_pinctrl_mux_ops *ops_data = NULL;
> + int rc;
> +
> + if (dev->device_node) {
> + const struct of_device_id *match;
> + match = of_match_node(at91_pinctrl_dt_ids, dev->device_node);
> + if (!match)
> + ops_data = NULL;
> + else
> + ops_data = (struct at91_pinctrl_mux_ops *)match->data;
> + }
> + else {
> + rc = dev_get_drvdata(dev, (unsigned long *)&ops_data);
> + if (rc)
> + ops_data = NULL;
> + }
Indentation looks garbled in this function.
> +
> + ret = pinctrl_register(&info->pctl);
> + if (ret)
> + return ret;
> +
> + dev_info(dev, "AT91 pinctrl registred\n");
s/registred/registered/
> +
> + ret = gpiochip_add(&at91_gpio->chip);
> + if (ret) {
> + dev_err(dev, "couldn't add gpiochip, ret = %d\n", ret);
> + return ret;
> + }
> +
> + dev_info(dev, "AT91 gpio driver registred\n");
here aswell.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
