Hi,
I resend this mail. My last one was malformed, because I tried to
answert this mail via smartphone while boring lecture at university.
On Wed, Jun 25, 2014 at 08:56:15AM +0200, Sascha Hauer wrote:
> On Tue, Jun 24, 2014 at 12:43:48PM +0200, Sebastian Hesselbarth wrote:
> > This adds pinctrl drivers for Marvell Dove and Kirkwood SoCs based
> > on a common driver stub. This design is based on the corresponding
> > Linux driver and should ease additional drivers for Marvell Armada
> > SoCs.
> >
> > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
>
> Applied with a small change:
>
> > +static int kirkwood_pinctrl_probe(struct device_d *dev)
> > +{
> > + const struct of_device_id *match =
> > + of_match_node(kirkwood_pinctrl_of_match, dev->device_node);
> > + struct mvebu_pinctrl_soc_info *soc =
> > + (struct mvebu_pinctrl_soc_info *)match->data;
> > +
> > + mpp_base = dev_request_mem_region(dev, 0);
>
> I added a return value check here. Not checking it means that the driver
> could do NULL pointer dereferences during runtime.
>
> I should really fix the places where the check is missing in the tree.
>
I spotted this also at my last patch for print warning for resource
conflicts and I thought a zero base address is also valid for some
cases.
Thats why I didn't add checks on null.
What I mean is that the dev_request_mem_region API reference can return
NULL which is for example "(void *)0x00000000" and is also valid. We
can't use this as error indicator.
Maybe we could change the API to:
int dev_request_mem_region_by_name(struct device_d *dev, void __iomem
**ptr, const char *name)
same for dev_request_mem_region. Then we can work with errno here and
set the old return via *ptr = foo. But would be a huge change in the API
or it's uncommon that somebody request iomem for NULL address... This
could happen for some memory locations.
- Alex
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
