On Wed, Mar 12, 2014 at 09:51:46PM +0100, Alexander Aring wrote: > Hi Sascha, > > On Wed, Mar 12, 2014 at 09:28:48PM +0100, Sascha Hauer wrote: > > On Mon, Mar 10, 2014 at 02:39:49PM +0300, Dmitry Lavnikevich wrote: > > > MTD internal API presently uses 32-bit values to represent device > > > size. This patch updates them to 64-bits but leaves the external API > > > unchanged. > > > > > > In general, changing from 32-bit to 64-bit values cause little > > > or no changes to the majority of the code with the following > > > exceptions: > > > - printk message formats; > > > - division and modulus of 64-bit values (mtd_div_by_wb, > > > mtd_div_by_eb may be used in some of such cases). > > > > > > Was tested on phyFLEX i.MX6. > > > > > > > changed master_offset to 64bit aswell and applied this series. > > > ok, cool! > > But.. damn it there is still a ugly comment in lib/libmtd.c: > > "NOTE: No support for 64 bit sizes yet!" Maybe this should be removed by somebody who has tested this code with devices > 4GB. I don't have the hardware for this. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
