Суббота, 1 февраля 2014, 19:13 +01:00 от Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>:
> On Fri, Jan 31, 2014 at 06:35:36PM +0400, Alexander Shiyan wrote:
> > Пятница, 31 января 2014, 15:23 +01:00 от Sascha Hauer
> <s.hauer@xxxxxxxxxxxxxx>:
> > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > > ---
> > > arch/arm/boards/karo-tx25/board.c | 130
> ++++++++++--------------------------
> > ...
> > > #define TX25_FEC_PWR_GPIO IMX_GPIO_NR(4, 9)
> > > #define TX25_FEC_RST_GPIO IMX_GPIO_NR(4, 7)
> > >
> > > +static struct gpio fec_gpios[] = {
> > > + {
> > > + .gpio = TX25_FEC_PWR_GPIO,
> > > + .flags = GPIOF_OUT_INIT_LOW,
> > > + .label = "fec-pwr",
> > > + }, {
> > > + .gpio = TX25_FEC_RST_GPIO,
> > > + .flags = GPIOF_OUT_INIT_LOW,
> > > + .label = "fec-rst",
> > > + },
> > > +};
> >
> > You have added these pins to DTS in PATCH 08/15.
> > What a reason to setup it twice?
>
> 08/15 only adds the pinctrl nodes. The code here is to power on the phy
> as we do not have regulator support yet.
Ok, I agree about PWR pin, but what about RST? Afaik we can handle
it from the FEC driver code.
---
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
