On Fri, Jan 31, 2014 at 06:35:36PM +0400, Alexander Shiyan wrote:
> Пятница, 31 января 2014, 15:23 +01:00 от Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>:
> > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > ---
> > arch/arm/boards/karo-tx25/board.c | 130 ++++++++++--------------------------
> ...
> > #define TX25_FEC_PWR_GPIO IMX_GPIO_NR(4, 9)
> > #define TX25_FEC_RST_GPIO IMX_GPIO_NR(4, 7)
> >
> > +static struct gpio fec_gpios[] = {
> > + {
> > + .gpio = TX25_FEC_PWR_GPIO,
> > + .flags = GPIOF_OUT_INIT_LOW,
> > + .label = "fec-pwr",
> > + }, {
> > + .gpio = TX25_FEC_RST_GPIO,
> > + .flags = GPIOF_OUT_INIT_LOW,
> > + .label = "fec-rst",
> > + },
> > +};
>
> You have added these pins to DTS in PATCH 08/15.
> What a reason to setup it twice?
08/15 only adds the pinctrl nodes. The code here is to power on the phy
as we do not have regulator support yet. Hm I just wonder if this works
as expected. I did the phy power on before the fec driver initializes,
but this also means that the phy power on is done before the pinctrl is
configured.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
