Hi,
On Fri, Jan 17, 2014 at 04:03:12PM +0100, Sascha Hauer wrote:
> More place for barebox.
>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> ---
> arch/arm/boards/phycard-i.MX27/env/config | 2 +-
> arch/arm/boards/phycard-i.MX27/pca100.c | 5 +++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boards/phycard-i.MX27/env/config b/arch/arm/boards/phycard-i.MX27/env/config
> index 9596311..9f10e7d 100644
> --- a/arch/arm/boards/phycard-i.MX27/env/config
> +++ b/arch/arm/boards/phycard-i.MX27/env/config
> @@ -39,7 +39,7 @@ autoboot_timeout=3
>
> bootargs="console=ttymxc0,115200"
>
> -nand_parts="256k(barebox)ro,128k(bareboxenv),2M(kernel),-(root)"
> +nand_parts="512k(barebox)ro,512k(bareboxenv),2M(kernel),-(root)"
First I through "2 MB for kernel?", but then I see you change this to 4MB
in another patch which introduce the new barebox env, so thats pretty cool.
:-)
> rootfs_mtdblock_nand=7
>
> # set a fancy prompt (if support is compiled in)
> diff --git a/arch/arm/boards/phycard-i.MX27/pca100.c b/arch/arm/boards/phycard-i.MX27/pca100.c
> index 2ff1b79..7ac0bf6 100644
> --- a/arch/arm/boards/phycard-i.MX27/pca100.c
> +++ b/arch/arm/boards/phycard-i.MX27/pca100.c
> @@ -21,6 +21,7 @@
> #include <mach/imx27-regs.h>
> #include <fec.h>
> #include <gpio.h>
> +#include <sizes.h>
> #include <asm/armlinux.h>
> #include <asm/sections.h>
> #include <generated/mach-types.h>
> @@ -287,10 +288,10 @@ static int pca100_devices_init(void)
> #endif
>
> nand = get_device_by_name("nand0");
I know, you don't make any change here but I though "What the hell do this
function here? Increase some reference count, because nand is never used
in this function?" Then I look a little bit deeper and it simple does
nothing... - Maybe we should remove this and the nand variable?
It's only a small hint which I detected.
- Alex
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
