Re: [PATCH 1/5] miitool: change behaviour closer to linux' mii-tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 25, 2013 at 11:50:01AM +0400, Antony Pavlov wrote:
> miitool without arguments will try to show status for all phys.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@xxxxxxxxx>
> +static void mdiobus_show(struct device_d *dev, char *phydevname, int verbose)
> +{
> +	struct mii_bus *mii = to_mii_bus(dev);
> +	int i, ret;

Applied this series with this unused variable removed...

> @@ -227,9 +244,6 @@ static int do_miitool(int argc, char *argv[])
>  		case 'v':
>  			verbose++;
>  			break;
> -		case 's':
> -			scan = 1;
> -			break;

...and also removed 's' from the options string.

This behaviour looks definitely better than what I did with the
additional 's' option.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux