On 19:19 Thu 28 Nov , Alexander Aring wrote:
> Hi,
>
> there are only some little nitpicks... maybe not important.
>
> On Thu, Nov 28, 2013 at 07:06:43PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > This will allow to do not check in each board which machine we are running
> > from. This work on DT & non-DT board.
> >
> > If only one board is enable autoselect it
> >
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
> > ---
> > arch/arm/cpu/Makefile | 2 +-
> > arch/arm/cpu/dtb.c | 8 +-
> > arch/arm/cpu/machine.c | 188 +++++++++++++++++++++++++++++++++++++
> > arch/arm/include/asm/barebox-arm.h | 8 ++
> > arch/arm/include/asm/mach/arch.h | 68 ++++++++++++++
> > arch/arm/lib/barebox.lds.S | 6 ++
> > 6 files changed, 277 insertions(+), 3 deletions(-)
> > create mode 100644 arch/arm/cpu/machine.c
> > create mode 100644 arch/arm/include/asm/mach/arch.h
> >
> > diff --git a/arch/arm/cpu/Makefile b/arch/arm/cpu/Makefile
> > index aba201b..78532da 100644
> ...
> > +
> > +int is_dt_compatible(const struct machine_desc *m, const char* dt_compat)
> > +{
> > + const char *const *dtc = m->dt_compat;
> const char *const *dtc? Looks like c ninja coding style :-D.
>
> I think you mean:
>
> const char **dtc = ...
>
no I mean this one both pointer are const It's very specific
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
