Don't call readline in if/else, instead setup a variable and call it once. Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> --- common/hush.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/common/hush.c b/common/hush.c index 5969127..0f1a9b9 100644 --- a/common/hush.c +++ b/common/hush.c @@ -420,15 +420,16 @@ static void get_user_input(struct in_str *i) { int n; static char the_command[CONFIG_CBSIZE]; + char *prompt; i->__promptme = 1; - if (i->promptmode == 1) { - n = readline(getprompt(), console_buffer, CONFIG_CBSIZE); - } else { - n = readline(CONFIG_PROMPT_HUSH_PS2, console_buffer, CONFIG_CBSIZE); - } + if (i->promptmode == 1) + prompt = getprompt(); + else + prompt = CONFIG_PROMPT_HUSH_PS2; + n = readline(prompt, console_buffer, CONFIG_CBSIZE); if (n == -1 ) { i->__promptme = 0; n = 0; -- 1.8.4.2 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox