On Wed, Nov 06, 2013 at 11:04:02AM +0100, Alexander Aring wrote: > Hi Sascha, > > On Wed, Nov 06, 2013 at 10:46:28AM +0100, Sascha Hauer wrote: > > Hi Andre, > > @@ -163,6 +163,13 @@ int register_framebuffer(struct fb_info *info) > > if (ret) > > goto err_unregister; > > > > + if (IS_ENABLED(CONFIG_DRIVER_VIDEO_SIMPLEFB)) { > > + ret = fb_register_simplefb(info); > > + if (ret) > > + dev_err(&info->dev, "failed to register simplefb: %s\n", > > + strerror(-ret)); > maybe we should return ret here? I think it's fine to continue without simplefb here. In the end the framebuffer works, just without simplefb. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox