On 14:41 Thu 31 Oct , Renaud Barbier wrote: > On 30/10/2013 11:34, Jean-Christophe PLAGNIOL-VILLARD wrote: > >> + barebox_set_model("Unknown"); > >> > + > >> > + /* Enable the GPIO Out pins */ > >> > + out_be32(gur + MPC85xx_GPIOCR_OFFSET, (gpiocr | MPC85xx_GPIOCR_GPOUT)); > > this should be GPIO API > >> > + > >> > + /* Enable NOR low voltage programming (gpio 2) an > > Note that here the code enables a CPU function that is, the whole block > of pins is enabled to be used as GPIO out pin. This does not specify the > pins direction but the pins function. > Of course, this can be wrap in a function specific to the CPU. > so this should use pinctrl API Best Regards, J. > _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox