On Tue, Oct 22, 2013 at 04:26:33PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 12:46 Tue 22 Oct , Markus Pargmann wrote:
> > KSZ8031 is similar to KSZ8021. It can use the same functions.
> >
> > Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx>
> > ---
> > drivers/net/phy/micrel.c | 9 +++++++++
> > include/linux/micrel_phy.h | 1 +
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> > index c0bcdd1..3cba2c4 100644
> > --- a/drivers/net/phy/micrel.c
> > +++ b/drivers/net/phy/micrel.c
> > @@ -122,6 +122,15 @@ static struct phy_driver ksphy_driver[] = {
> > .config_aneg = genphy_config_aneg,
> > .read_status = genphy_read_status,
> > }, {
> > + .phy_id = PHY_ID_KSZ8031,
> > + .phy_id_mask = 0x00ffffff,
> > + .drv.name = "Micrel KSZ8031",
> > + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause |
> > + SUPPORTED_Asym_Pause),
> > + .config_init = ksz8021_config_init,
> > + .config_aneg = genphy_config_aneg,
> > + .read_status = genphy_read_status,
> > +}, {
> > .phy_id = PHY_ID_KSZ8041,
> > .phy_id_mask = 0x00fffff0,
> > .drv.name = "Micrel KSZ8041",
> > diff --git a/include/linux/micrel_phy.h b/include/linux/micrel_phy.h
> > index 9dbb41a..8752dbb 100644
> > --- a/include/linux/micrel_phy.h
> > +++ b/include/linux/micrel_phy.h
> > @@ -19,6 +19,7 @@
> > #define PHY_ID_KSZ9021 0x00221610
> > #define PHY_ID_KS8737 0x00221720
> > #define PHY_ID_KSZ8021 0x00221555
> > +#define PHY_ID_KSZ8031 0x00221556
> you really need this?
>
> because if you use a phy_id_mask of 0x00fffff0 you can use the entry as
> PHY_ID_KSZ8021
Yes, it is necessary, the mask you suggest is already in use for
#define PHY_ID_KSZ8051 0x00221550
Regards,
Markus Pargmann
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
