Re: [PATCH] mci: omap: Fix default value of mci.f_max

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14:19 Fri 27 Sep     , Alexander Aring wrote:
> Hi,
> 
> On Fri, Sep 27, 2013 at 02:13:00PM +0200, Teresa Gámez wrote:
> > Set default value of mci.f_max even when no pdata
> > is available.
> > 
> > Signed-off-by: Teresa Gámez <t.gamez@xxxxxxxxx>
> > ---
> >  drivers/mci/omap_hsmmc.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mci/omap_hsmmc.c b/drivers/mci/omap_hsmmc.c
> > index a2cd3fe..f63697f 100644
> > --- a/drivers/mci/omap_hsmmc.c
> > +++ b/drivers/mci/omap_hsmmc.c
> > @@ -614,11 +614,11 @@ static int omap_mmc_probe(struct device_d *dev)
> >  	if (pdata) {
> >  		if (pdata->f_max)
> >  			hsmmc->mci.f_max = pdata->f_max;
> > -		else
> > -			hsmmc->mci.f_max = 52000000;
> 
> I think this should stay there for the case if f_max is zero.
> So somebody sets a pdata with devname and no f_max value.
> 
> 
> Maybe you should add a default devname if no pdata is given.
no there is a default devname disk.%d
> 
> - Alex
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox





[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux