On 10:55 Fri 27 Sep , Sascha Hauer wrote:
> On Fri, Sep 27, 2013 at 09:14:14AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > so enable the uart only if used
> > so linux can detect the right one enable if it want
> >
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
> > ---
> > common/console.c | 6 ++++++
> > common/console_common.c | 36 ++++++++++++++++++++++++++++++++++++
> > common/console_simple.c | 3 +++
> > include/console.h | 4 ++++
> > 4 files changed, 49 insertions(+)
> >
> > diff --git a/common/console.c b/common/console.c
> > index 56bc864..00fd2cf 100644
> > --- a/common/console.c
> > +++ b/common/console.c
> > @@ -83,8 +83,14 @@ static int console_std_set(struct device_d *dev, struct param_d *param,
> >
> > if (flag && !cdev->f_active) {
> > /* The device is being activated, set its baudrate */
> > + if (cdev->startup)
> > + cdev->startup(cdev);
> > if (cdev->setbrg)
> > cdev->setbrg(cdev, cdev->baudrate);
> > + } else if (!flag && cdev->f_active) {
> > + /* The device is being desactivated, shutdown it */
>
> /* The device is being deactivated, shut it down */
>
> > +
> > +int console_open(struct console_device *cdev)
> > +{
> > + int ret;
> > +
> > + if (cdev->f_active)
> > + return 0;
> > +
> > + if (cdev->startup) {
> > + ret = cdev->startup(cdev);
> > + if (ret)
> > + return ret;
> > + }
> > +
> > + if (cdev->setbrg) {
> > + cdev->baudrate = CONFIG_BAUDRATE;
>
> I believe cdev->baudrate should be set only once during initialization.
> When I deactivate a console and activate it again I don't expect the
> baudrate to be changed to it's default value.
maybe but if the device is not a console but rs485 you never set the baudrate
today same if a device is never active
as example use a non active device for loadxy
so I'm think that the console_open is more like man 2 open + ioctl to use a
cdev
later we will switch to open + ioctl API
for now on I prefer to just fix the big issues and prepare to switch easly
Best Regards,
J.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
