Hi Renaud, On Tue, Jun 25, 2013 at 11:45:30AM +0100, Renaud Barbier wrote: > This commit adds support to calculate the DDR2 SPD checksum as per > JEDEC standard No 21-C Appendix X (revision 1.2) This code is from U-Boot. Please say so in the commit message, possibly also which commit you used. Also for the other patches. Wolfgang once complained about not doing so for code we used from U-Boot. > +uint32_t ddr2_spd_check(const struct ddr2_spd_eeprom_s *spd) The function name is a poor choice as it doesn't give a clue about its return value. Does it return 'Yes, the check failed" or "Yes, the check is ok"?. Please rename to something like ddr2_spd_checksum_ok. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
