Re: [PATCH] devfs-core: introduce devfs_append_partition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 18, 2013 at 02:50:50PM +0200, Jan Luebbe wrote:
> This simplifies board code for partition setup by keeping track of the
> offset.
> 
> Signed-off-by: Jan Luebbe <jlu@xxxxxxxxxxxxxx>

Good idea. There seem to be some bugs in this area. I'm fine with the
patch when some users are converted to this.

Sascha

> ---
>  fs/devfs-core.c  | 9 +++++++++
>  include/driver.h | 2 ++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/fs/devfs-core.c b/fs/devfs-core.c
> index 262e0a2..f7d79ff 100644
> --- a/fs/devfs-core.c
> +++ b/fs/devfs-core.c
> @@ -267,6 +267,15 @@ int devfs_add_partition(const char *devname, loff_t offset, loff_t size,
>  	return 0;
>  }
>  
> +int devfs_append_partition(const char *devname, loff_t *offset, loff_t size,
> +		int flags, const char *name)
> +{
> +	int ret;
> +	ret = devfs_add_partition(devname, *offset, size, flags, name);
> +	*offset += size;
> +	return ret;
> +}
> +
>  int devfs_del_partition(const char *name)
>  {
>  	struct cdev *cdev;
> diff --git a/include/driver.h b/include/driver.h
> index 716f792..3f4f7b9 100644
> --- a/include/driver.h
> +++ b/include/driver.h
> @@ -463,6 +463,8 @@ int cdev_erase(struct cdev *cdev, size_t count, loff_t offset);
>  
>  int devfs_add_partition(const char *devname, loff_t offset, loff_t size,
>  		int flags, const char *name);
> +int devfs_append_partition(const char *devname, loff_t *offset, loff_t size,
> +		int flags, const char *name);
>  int devfs_del_partition(const char *name);
>  
>  #define DRV_OF_COMPAT(compat) \
> -- 
> 1.8.3.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux