On Wed, May 22, 2013 at 05:54:16PM +0100, Renaud Barbier wrote: > This patch supports the erasing of CFI flash with non-uniform sector. > When more than one erase region exists, the mtd_erasesize function > assigns the erase size of the sector to the erase_info structure. > > The problem was discovered when erasing /dev/env0 on my PPC board. > This is a partition of size 0x8000 at offset 0 of a 32MB Intel compatible > flash with a bottom boot block i.e 4 32KB sectors followed by 255 > 128KB sectors. > > barebox> unprotect /dev/env0 > barebox> erase /dev/env0 > cfi_erase: start = 0x0, end = 0x3, count = 0x20000 > Flash erase error at address fe008000 > Block Erase Error. > Block locked. > erase: I/O error > > The error above is that a count of 0x20000 is passed instead of 0x8000 > by mtd_op_erase. This is because the code does not take into account > multiple erase regions. > > After taking into account the erase regions, only the first sector is > erased: > > barebox> unprotect /dev/env0 > barebox> erase /dev/env0 > cfi_erase: start = 0x0, end = 0x0, count = 0x8000 > > Signed-off-by: Renaud Barbier <renaud.barbier@xxxxxx> Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
