Dear Sebastian Hesselbarth, On Sun, 19 May 2013 12:49:31 +0200, Sebastian Hesselbarth wrote: > But I will not start working on it before Thomas finds some time to > test/comment on the (not yet) published consolidation patches. I had a look at them, and it looks great to me. The only problem that I could see from a quick review is that your patch "arm: mvebu: introduce common console UART config" breaks functional bisectability because it moves the UART used for earlyprintk from 0xd0 to 0xf1, even though the SoC and board code is not yet migrated to use the common lowlevel code that does the remapping at 0xf1. I'm personally not overly choked if the functional bisectability is broken at this point, but maybe Sascha will. I believe you should simply post your patches on the list, there's no need to get a prior ack from me. Maybe we can simply ask Sascha to wait for your opinion on my patches, and my opinion on your patches before applying them? I very much prefer to see patches being posted publicly rather than having those 'private' reviews. Sascha, are you ok? Thanks for your work Sebastian! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
