Hi Thomas, On Sat, May 04, 2013 at 07:52:28PM +0200, Thomas Petazzoni wrote: > Dear Jason Cooper, > > On Sat, 4 May 2013 13:15:30 -0400, Jason Cooper wrote: > > > Great work! Very clean series. I only have one thought. Prafulla > > (u-boot kirkwood maintainer) is always asking about consolidating the > > kwbimage.cfg files. The three you've submitted for the first three > > boards are almost (if not entirely) identical. Before a whole bunch of > > boards get added, should we make a kwbimage-common.cfg or similar? > > I'm not sure I want to make the configuration language more complicated > than it is already. It's already a pain to parse such a configuration > file in C (I would have preferred to write the kwbimage tool in Python, > but since all existing Barebox tools are in C, I wasn't sure a Python > tool would have been accepted). Adding the support for includes means > that you have to recursively handle includes, etc. I'm not sure I want > to go down this road for files that typically have between 10 to 30 > lines. How about using the C preprocessor for includes if they become necessary? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
