On Thu, Apr 11, 2013 at 02:04:51PM +0200, Eric Bénard wrote: > actually ops.ooboffs is not defaulted so when its value gets > added to chip->oob_poi in nand_fill_oob or nand_transfer_oob > the respective memcpy is using a wrong address. > > With this patch, both md -s /dev/nandraw0 and cp xyz /dev/nandraw0.sb > are working fine on an i.MX28 target (instead of crashing the board). > > Signed-off-by: Eric Bénard <eric@xxxxxxxxxx> Applied, thanks Sascha > --- > drivers/mtd/mtdraw.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/mtdraw.c b/drivers/mtd/mtdraw.c > index 384104e..c289e8d 100644 > --- a/drivers/mtd/mtdraw.c > +++ b/drivers/mtd/mtdraw.c > @@ -98,6 +98,7 @@ static ssize_t mtdraw_read_unaligned(struct mtd_info *mtd, void *dst, > if (!tmp) > return -ENOMEM; > ops.mode = MTD_OOB_RAW; > + ops.ooboffs = 0; > ops.datbuf = tmp; > ops.len = mtd->writesize; > ops.oobbuf = tmp + mtd->writesize; > @@ -152,6 +153,7 @@ static ssize_t mtdraw_blkwrite(struct mtd_info *mtd, const void *buf, > int ret; > > ops.mode = MTD_OOB_RAW; > + ops.ooboffs = 0; > ops.datbuf = (void *)buf; > ops.len = mtd->writesize; > ops.oobbuf = (void *)buf + mtd->writesize; > -- > 1.7.11.7 > > > _______________________________________________ > barebox mailing list > barebox@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/barebox -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
