On 09:16 Tue 09 Apr , Sascha Hauer wrote:
> On Mon, Apr 08, 2013 at 09:17:15AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 00:15 Mon 08 Apr , Christoph Fritz wrote:
> > > This patch adds omap4 display controller support.
> > >
> > > +
> > > +static inline void fb_write(uint32_t v, void __iomem *addr)
> > > +{
> > > + __raw_writel(v, addr);
> > > +}
> > > +
> > > +static inline uint32_t fb_read(void const __iomem *addr)
> > > +{
> > > + return __raw_readl(addr);
> > > +}
> > what is the dif?
>
> Maybe Christoph understands what you mean here. I don't
those 2 inline as useless
>
> > > +
> > > + fbi->regs.dss = dev_request_mem_region(dev, OMAP4_FB_RESOURCE_DSS);
> > > + fbi->regs.dispc = dev_request_mem_region(dev, OMAP4_FB_RESOURCE_DISPC);
> > use named dev_request
>
> We don't have such a function.
yes we do
dev_request_mem_region_by_name
>
> Could you please trim the context to sensible limits when reviewing
> patches? It's hard to find your comments when you keep the complete
> patch.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
