Re: [PATCH 1/2] Makefile: Create empty <config.h> if this header file is not needed by board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 11, 2013 at 08:10:49PM +0400, Alexander Shiyan wrote:
> Patch creates empty <config.h> if this header is not needed by board.
> This will allow to remove many empty config.h files from boards.
> 
> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> ---
>  Makefile | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index b5819fc..e8d9984 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -898,13 +898,18 @@ include/asm:
>  	$(Q)$(check-symlink)
>  	$(Q)$(create-symlink)
>  
> +define symlink-config-h
> +	if [ -f $(srctree)/$(BOARD)/config.h ]; then		\
> +		$(kecho) '  SYMLINK $@ -> $(BOARD)/config.h';	\
> +		ln -fsn $(srctree)/$(BOARD)/config.h $@;	\
> +	else							\
> +		$(kecho) '  CREATE  $@';			\
> +		echo -n > $@;					\
> +	fi
> +endef

I dropped this patch because it autogenerates files which were
previously part of the repository. This causes git checkout to
complain about overwriting existing files when we want to checkout
earlier versions.

How about creating this patch like this:

- create (and commit) a include/config-empty.h
- link to the board specific config.h if it exists or to
  config-empty.h if it doesn't exist.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux