For some reasons relative to my company , I'm not able to send emails
using git-send-email. I gave up.
Thanks.
On jeudi 14 mars 2013 08:35:41, Sascha Hauer wrote:
> On Wed, Mar 13, 2013 at 02:44:39PM +0100, Cerrato Renaud wrote:
>> This patch fix a possible null pointer dereference exception because of a missing null check on cdev->config
>>
>> Signed-off-by: Cerrato Renaud <r.cerrato@xxxxxxxxxxxxxxxxxxx>
>> ---
>> drivers/usb/gadget/composite.c | 23 +++++++++++++----------
>> 1 files changed, 13 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
>> index 9af115e..1f6c5b2 100644
>> --- a/drivers/usb/gadget/composite.c
>> +++ b/drivers/usb/gadget/composite.c
>> @@ -777,18 +777,21 @@ unknown:
>> * recipients (endpoint, other, WUSB, ...) to the current
>> * configuration code.
>> */
>> - f = cdev->config->interface[intf];
>> - if (f && f->setup)
>> - value = f->setup(f, ctrl);
>> - else
>> - f = NULL;
>> + if(cdev->config) {
>
> please do a:
>
> if (!cdev->config)
> goto out;
>
> instead.
>
> Your patch is whitespace damaged, I won't be able to apply it.
> As Jean-Christophe mentioned, you should use git-send-mail for sending
> your patches. It does things just right.
>
> Sascha
>
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
