Hello.
Only few questions inlined.
> This adds support for the various DDR calibration functions in the
> i.MX6 MMDC.
...
> +static inline u32 reg32_read(u32 reg)
> +{
> + return readl(reg);
> +}
> +
> +static inline void reg32_write(u32 reg, u32 val)
> +{
> + writel(val, reg);
> +}
> +
What a reason to separate functions instead of readl/writel?
> +static inline void reg32setbit(u32 reg, int bit)
> +{
> + u32 val;
> +
> + val = readl(reg);
> + val |= 1 << bit;
> + writel(val, reg);
> +}
> +
> +static inline void reg32clrbit(u32 reg, int bit)
> +{
> + u32 val;
> +
> + val = readl(reg);
> + val &= ~(1 << bit);
> + writel(val, reg);
> +}
Maybe move this into asm-generic/io.h? Seems it can be reused by other
users.
Thanks.
---
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
