Hi Alexander, On Fri, Feb 15, 2013 at 10:49:27PM +0400, Alexander Shiyan wrote: > This patch adds generic memory-mapped GPIO controller support. > Code taken from Linux Kernel and adopted for barebox. I'm fine with this if you add a user for it. I wonder though if it's worth it to have this driver for barebox. If I have a driver in the kernel that already uses it, then this makes it simple to copy it, but should I have to write a new gpio driver, I'm unsure if it's simpler to write a new gpio driver or to register with the generic gpio driver. > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 89be684..565f5bd 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -6,10 +6,20 @@ if GPIOLIB > > menu "GPIO" > > +config GPIO_GENERIC > + def_bool y > + Please do not unconditionally enable this for all configs. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
