__dev_printf is a define which uses a local variable 'ret'. This
means that whenever someone does a dev_*(dev, "ret: %d\n", ret);
ret will be 0.
Fix this by removing the variable. The return value of dev_* is
never checked anyway.
Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
---
I'm glad it was myself who stumbled upon this...
include/printk.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/printk.h b/include/printk.h
index 1d45616..3f8f786 100644
--- a/include/printk.h
+++ b/include/printk.h
@@ -23,10 +23,8 @@ int dev_printf(const struct device_d *dev, const char *format, ...)
#define __dev_printf(level, dev, format, args...) \
({ \
- int ret = 0; \
if (level <= LOGLEVEL) \
- ret = dev_printf(dev, format, ##args); \
- ret; \
+ dev_printf(dev, format, ##args); \
})
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
