First I tried to change getopt optstring argument to "const char *" and I test it with an allyesconfig for compiler warnings. Then there popup some compile errors, which I tried to fix. I am not happy with some of these solutions. Maybe someone have an idea how we can make it better. hush: add getopt only if it enabled - I don't know if this needs a fix. But if we disable getopt there is a no-op getopt implementation in the command list. This patch don't add getopt to the command list at runtime, but the no-op implementation is still there. Maybe a compiletime solution is better to remove the no-op implementation. sata-imx: fix depends on ARCH_IMX - I am not sure but this looks like ARCH_IMX related things. I got a error that some imx51 header files could'nt be found. net: fix cpsw depends on ARCH_OMAP - Same thing like sata-imx. I got a compile error that mach/cpsw.h wasn't found. I only found that in the omap implementation. Another (maybe toolchain related issue) is: barebox/lib/libubigen.c:105: undefined reference to `__divdi3' Is it in this line: tmp = (vi->bytes + ui->leb_size - 1) / ui->leb_size; If we know that ui->leb_size is a power-of-two, we can use a shift for this instead of division. But I don't know if leb_size a power-of-two number. v2: - fix commit msg in "net: fix cpsw depends on ARCH_OMAP" patch Alexander Aring (4): hush: add getopt only if it enabled getopt: change optstring to const char* sata-imx: fix depends on ARCH_IMX net: fix cpsw depends on ARCH_OMAP common/hush.c | 3 ++- drivers/ata/Kconfig | 1 + drivers/net/Kconfig | 1 + include/getopt.h | 2 +- lib/getopt.c | 4 ++-- 5 files changed, 7 insertions(+), 4 deletions(-) -- 1.8.1.2 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
