On Tue, Jan 29, 2013 at 10:58:01AM +0100, Jan Luebbe wrote:
> Previously, during a multi-page write, chip->oob_poi would not be
> reinitialized.
>
> Signed-off-by: Jan Luebbe <jlu@xxxxxxxxxxxxxx>
> ---
> drivers/mtd/nand/nand_write.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_write.c b/drivers/mtd/nand/nand_write.c
> index 9997127..f4f2fed 100644
> --- a/drivers/mtd/nand/nand_write.c
> +++ b/drivers/mtd/nand/nand_write.c
> @@ -296,15 +296,15 @@ int nand_do_write_ops(struct mtd_info *mtd, loff_t to,
> (chip->pagebuf << chip->page_shift) < (to + ops->len))
> chip->pagebuf = -1;
>
> - /* Initialize to all 0xFF, to avoid the possibility of
> - left over OOB data from a previous OOB read. */
> - memset(chip->oob_poi, 0xff, mtd->oobsize);
> -
> while(1) {
> int bytes = mtd->writesize;
> int cached = writelen > bytes && page != blockmask;
> uint8_t *wbuf = buf;
>
> + /* Initialize to all 0xFF, to avoid the possibility of
> + left over OOB data from a previous OOB read or write. */
> + memset(chip->oob_poi, 0xff, mtd->oobsize);
> +
/*
* Can you please fix the comment format while here?
*/
Does this fix a problem you found?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
