On Wed, Jan 23, 2013 at 09:43:19PM +0100, Alexander Aring wrote: > On Wed, Jan 23, 2013 at 09:30:51PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 21:25 Wed 23 Jan , Alexander Aring wrote: > > > Hi Sascha, > > > > > > On Wed, Jan 23, 2013 at 09:18:44PM +0100, Sascha Hauer wrote: > > > > Hi Alexander, > > > > > > > > On Wed, Jan 23, 2013 at 09:01:36PM +0100, Alexander Aring wrote: > > > > > > > +/* > > > > > > > + * PTE flags variables to set cached and > > > > > > > + * uncached regions. > > > > > > > + */ > > > > > > > +static uint32_t PTE_FLAGS_CACHED; > > > > > > > +static uint32_t PTE_FLAGS_UNCACHED; > > > > > > > > > > > > Please no uppercase letters for variable names. > > > > > > > > > > > Ok. I took it from mach/arm/cpu/mmu.c, should I create a patch which > > > > > rename it in arch/arm/cpu/mmu.c lower case, too? > > > > > > > > Yes, that would be great. I must have forgotten reviewing my own patch > > > > ;) > > > > > > > > > > > > > > > > +#else > > > > > > > +static char optstr[] = "s:e:i:b"; > > > > > > > +#endif > > > > > > > + > > > > > > > +/* > > > > > > > + * Perform a memory test. The complete test > > > > > > > + * loops until interrupted by ctrl-c. > > > > > > > + */ > > > > > > > +static int mem_test(vu_long _start, vu_long _end, > > > > > > > + int bus_only) > > > > > > > > > > > > It would be good to move this function to common/memory_test.c. This way > > > > > > it could be called from C. Especially testing memory might be called > > > > > > from some early small (no shell) development binaries which are running from some > > > > > > internal SRAM. > > > > > > > > > > > Ok. > > > > > Maybe we can do a menu entry via Kconfig or something else to run a > > > > > memtest after booting automatically. > > > > > > > > Maybe this could be added as an init script in the environment, but > > > > personally I don't think I'll run it by default on our boards. We are > > > > more into booting fast. > > > But how will you run the memtest command in a (no shell) environment? :) > > make as an option but this will be board specific > > > > I do not want it by default too > > > > booting time are critical for a lost of client > > > > Best Regards, > > J. > Ok, hold on. > We want this to move it in common/memory_test.c to call memtest in a > (no shell) environment for a small barebox which running in the internal > sram(like omap MLO), not in the connected "ram". > > This can be useful to test the complete "connected ram" without allocated > barebox regions. > > But to do this in a (no shell) environment, somebody need to modify some > code to call memtest at barebox boot. Or? Yes, he would have to modify code. I assumed that he is in the middle of bootstrapping a new board, so he will be writing code anyway. If that assumption is wrong such an option might indeed be useful. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
